Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_yarn_linear_ramp_mask() missing 1 required positional argument: 'device' #2904

Closed
Anditty opened this issue Feb 18, 2024 · 1 comment
Closed

Comments

@Anditty
Copy link

Anditty commented Feb 18, 2024

In vllm/model_executor/layers/rotary_embedding.py, function _yarn_linear_ramp_mask need a parameter device and it doesn't have a default value, but in line:307: inv_freq_mask = (1 - _yarn_linear_ramp_mask(low, high, self.rotary_dim // 2, dtype=torch.float)) * self.extrapolation_factor don't use this parameter.

@44670
Copy link
Contributor

44670 commented Feb 21, 2024

+1, Perhaps we should deploy a static syntax checker in the GitHub Actions of this project.

44670 added a commit to 44670/vllm that referenced this issue Feb 21, 2024
44670 added a commit to 44670/vllm that referenced this issue Feb 22, 2024
@hmellor hmellor closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants