-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: flakey test found in #7874 #8051
Labels
bug
Something isn't working
Comments
noooop
added a commit
to noooop/vllm
that referenced
this issue
Aug 31, 2024
noooop
added a commit
to noooop/vllm
that referenced
this issue
Aug 31, 2024
noooop
added a commit
to noooop/vllm
that referenced
this issue
Aug 31, 2024
noooop
added a commit
to noooop/vllm
that referenced
this issue
Aug 31, 2024
Will try setting higher NUM_LOGPROBS for fp8e4m3 as the test is simply whether sampled for one is in top K log probs of reference and vice versa |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#7874 adjusted chunked prefill the scheduling order
fp8_e4m3 model FAILED
FAILED basic_correctness/test_chunked_prefill.py::test_models_with_fp8_kv_cache[True-1-False-4-4-fp8_e4m3-nm-testing/Qwen2-1.5B-Instruct-FP8-K-V] - AssertionError: Test7:
FAILED basic_correctness/test_chunked_prefill.py::test_models_with_fp8_kv_cache[True-1-True-4-4-fp8_e4m3-nm-testing/Qwen2-1.5B-Instruct-FP8-K-V] - AssertionError: Test7:
but bf16 model PASS
tests/basic_correctness/test_chunked_prefill.py::test_models_with_fp8_kv_cache[True-1-False-4-4-auto-Qwen/Qwen2-1.5B-Instruct]
tests/basic_correctness/test_chunked_prefill.py::test_models_with_fp8_kv_cache[True-1-True-4-4-auto-Qwen/Qwen2-1.5B-Instruct]
Test 7 is stuck on the resolution of fp8_e4m3,
🐛 Describe the bug
as @jon-chuang said:
The test using top k log probs may have been bound to be flakey. Perhaps testing style like this is more reliable especially given hardware differences or drift across kernels. #8013
(However note that this is just top 1 log probs I.e. greedy decode so not sure if even this testing strategy will be reliable)
Before submitting a new issue...
The text was updated successfully, but these errors were encountered: