-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4/N][torch.compile] clean up set_torch_compile_backend #10401
[4/N][torch.compile] clean up set_torch_compile_backend #10401
Conversation
Signed-off-by: youkaichao <youkaichao@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I don't think I'm the right person to review this PR; I don't have enough background 😅. However, since the PR seems to be well scoped and is mostly minor refactoring, please go ahead and merge the PR if no one else can review this.
…#10401) Signed-off-by: youkaichao <youkaichao@gmail.com>
…#10401) Signed-off-by: youkaichao <youkaichao@gmail.com>
…#10401) Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
…#10401) Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: rickyx <rickyx@anyscale.com>
…#10401) Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
…#10401) Signed-off-by: youkaichao <youkaichao@gmail.com>
…#10401) Signed-off-by: youkaichao <youkaichao@gmail.com>
after #10383 , we can store much information in the compilation config, rather than leaving them as global variables.