Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update doc for LoRA support in GLM-4V #10425

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

B-201
Copy link
Contributor

@B-201 B-201 commented Nov 18, 2024

Since #10418 added LoRA support for the GLM-4V, the Supported Models page needs to be updated accordingly.
ping @DarkLight1337

Signed-off-by: B-201 <Joy25810@foxmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 18, 2024
@Isotr0py Isotr0py enabled auto-merge (squash) November 18, 2024 14:21
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 18, 2024
@Isotr0py Isotr0py merged commit 4186be8 into vllm-project:main Nov 18, 2024
40 of 43 checks passed
mikejuliet13 pushed a commit to mikejuliet13/vllm that referenced this pull request Nov 19, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Signed-off-by: Manjul Mohan <manjul.mohan@ibm.com>
coolkp pushed a commit to coolkp/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Signed-off-by: rickyx <rickyx@anyscale.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
prashantgupta24 pushed a commit to opendatahub-io/vllm that referenced this pull request Dec 3, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 10, 2025
Signed-off-by: B-201 <Joy25810@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants