Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc][XPU] Avoid torch compile for XPU platform #10747

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

yma11
Copy link
Contributor

@yma11 yma11 commented Nov 28, 2024

After torch.jit.script --> torch.compile in PR, triton is eventually called during tensor parallel on XPU platform. We need disable torch.compile() for xpu.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yma11
Copy link
Contributor Author

yma11 commented Nov 29, 2024

@youkaichao can you take a review on this PR?

@@ -25,6 +26,8 @@ def load_general_plugins():
os.environ['TORCHINDUCTOR_COMPILE_THREADS'] = '1'
# see https://github.com/vllm-project/vllm/issues/10619
torch._inductor.config.compile_threads = 1
if current_platform.is_xpu():
os.environ['TORCH_COMPILE_DISABLE'] = 'True'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any documentation for this env var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean where this config comes from? If so, please refer here.

@youkaichao youkaichao enabled auto-merge (squash) December 2, 2024 07:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 2, 2024
@youkaichao
Copy link
Member

I think we need more intel gpus for testing. it has been waiting for very long. cc @jikunshang @yma11

@zhouyuan
Copy link
Contributor

zhouyuan commented Dec 2, 2024

We recently modified the intel cpu/gpu queue to run against "CI pipeline", I guess the migration work is still in progress
CC @khluu for his comments

-yuan

yma11 and others added 4 commits December 2, 2024 21:55
Signed-off-by: yan ma <yan.ma@intel.com>
Signed-off-by: yan ma <yan.ma@intel.com>
Signed-off-by: yan ma <yan.ma@intel.com>
@youkaichao youkaichao merged commit 519cc6c into vllm-project:main Dec 2, 2024
57 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: yan ma <yan.ma@intel.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Signed-off-by: yan ma <yan.ma@intel.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants