- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 11k
 
[Misc] Split up pooling tasks #10820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Split up pooling tasks #10820
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
| 
           👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these: 
 🚀  | 
    
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
b4964ad    to
    5d3a629      
    Compare
  
    3627461    to
    39f7d7c      
    Compare
  
    Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
39f7d7c    to
    11fbad1      
    Compare
  
    Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
| 
           cc @russellb see if these new doc additions look good to you!  | 
    
| 
           @Isotr0py would be great if you could review this as well!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Just a comment about the score task.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
As part of #10674, split up the
embeddingtask into the following tasks for pooling models:embed), with default poolerpooling_type=LAST, normalize=Trueclassify), with default poolerpooling_type=LAST, softmax=Truescoring)reward), with default poolerpooling_type=ALLpeiyi9979/math-shepherd-mistral-7b-prmconflicting with otherLlamaForCausalLMpooling models, we will remove the pooler default from the text generation model. Since users already have to overridestep_tag_idetc. anyway to use that model, this should not be a major breaking change.Backwards compatibility
embeddingremains available as an alias toembed.--task embeddingis passed but the requested pooling model is not an embedding model, a deprecation warning is emitted.--task embeddingexclusive to embedding models.