-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1][Bugfix] Fix V1 TP trust-remote-code #11182
[V1][Bugfix] Fix V1 TP trust-remote-code #11182
Conversation
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
@youkaichao you maybe have a better idea but for now I'm marking this ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what's wrong here. We might need further investigation.
But I'm good with this change if it solves the issue at present.
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: Bowen Wang <abmfy@icloud.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
When running in V1 with TP:
This fixes the following error