Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Add BNB quantization for Whisper #12381

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Jan 24, 2025

No description provided.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link

mergify bot commented Jan 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jeejeelee.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 24, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee marked this pull request as draft January 24, 2025 03:09
@mergify mergify bot removed the needs-rebase label Jan 24, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee requested a review from mgoin January 25, 2025 16:27
@jeejeelee jeejeelee marked this pull request as ready for review January 25, 2025 16:27
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this looks good to me! Will this work with a weight load test from a prequantized checkpoint?

@jeejeelee
Copy link
Collaborator Author

Sorry for the delay, this looks good to me! Will this work with a weight load test from a prequantized checkpoint?

I have tested both online and offline quantization locally, and both were able to generate reasonable results

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 4, 2025
@youkaichao youkaichao merged commit 96b2362 into vllm-project:main Feb 4, 2025
54 of 61 checks passed
@jeejeelee jeejeelee deleted the whsiper-bnb branch February 4, 2025 10:06
fxmarty-amd pushed a commit to fxmarty-amd/vllm that referenced this pull request Feb 7, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Felix Marty <felmarty@amd.com>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants