-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Support override generation config in args #12409
[Frontend] Support override generation config in args #12409
Conversation
Signed-off-by: liuyanyi <wolfsonliu@163.com>
Signed-off-by: liuyanyi <wolfsonliu@163.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
vllm/engine/arg_utils.py
Outdated
default=None, | ||
help="Override or set generation config. " | ||
"Defaults to None, will use for the default generation config. " | ||
"e.g. ``{\"temperature\": 0.5, \"top_k\": 50}``.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the use of "auto" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean the "auto" for "--generation-config"?
if auto is set, will load generation config from model dir, "--override-generation-config" allow user to manually set the generation config.
I think the newly added test should show the behavior between these parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, can you update the help string to include this information?
Signed-off-by: liuyanyi <wolfsonliu@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving on this!
Please merge from main to fix the merge conflicts. |
Head branch was pushed to by a user without write access
Done |
…2409) Signed-off-by: liuyanyi <wolfsonliu@163.com>
…2409) Signed-off-by: liuyanyi <wolfsonliu@163.com> Signed-off-by: Isotr0py <2037008807@qq.com>
…2409) Signed-off-by: liuyanyi <wolfsonliu@163.com>
…2409) Signed-off-by: liuyanyi <wolfsonliu@163.com>
…2409) Signed-off-by: liuyanyi <wolfsonliu@163.com>
|
|
Support override generation config in args
In my past pr #11164, generation config could be load from model or other file.
In this pr, generation config can be override by user in args or model config, this allow control generation config in cli args.
override_generation_config
has been added to ModelConfig and EngineArgs. A test has been added too.Example Usage:
vllm serve Qwen/Qwen2.5-1.5B-Instruct --override-generation-config "{"top_k": 5}"
log will shows