Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ?device={device} when changing tab in installation guides #12560

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Set ?device={device} when changing tab in installation guides #12560

merged 2 commits into from
Jan 30, 2025

Conversation

hmellor
Copy link
Collaborator

@hmellor hmellor commented Jan 29, 2025

@hmellor
Set ?device={device} when changing tab in installation guides
27aa210 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 29, 2025
mgoin
mgoin approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you. Could you add a comment to describe the purpose? It is quite opaque to me since I don't write JS

@hmellor
Add comments to custom.js code
9a9d2ba 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@simon-mo simon-mo merged commit a276903 into vllm-project:main Jan 30, 2025
16 of 18 checks passed
@hmellor hmellor changed the title Set ?device={device} when changing tab in installation guides Make installation guides more sharable and more discoverable Jan 30, 2025
@hmellor hmellor changed the title Make installation guides more sharable and more discoverable Set ?device={device} when changing tab in installation guides Jan 30, 2025
@hmellor hmellor deleted the better-tab-handling branch January 30, 2025 10:52
rasmith pushed a commit to rasmith/vllm that referenced this pull request Jan 30, 2025
@hmellor @rasmith
Set ?device={device} when changing tab in installation guides (vllm…
96664d6 
…-project#12560)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
@hmellor @Isotr0py
Set ?device={device} when changing tab in installation guides (vllm…
5058563 
…-project#12560)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
youngkent pushed a commit to youngkent/vllm that referenced this pull request Feb 3, 2025
@hmellor @youngkent
Set ?device={device} when changing tab in installation guides (vllm…
9105921 
…-project#12560)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
srikanthsrnvs pushed a commit to srikanthsrnvs/vllm that referenced this pull request Feb 3, 2025
@hmellor @srikanthsrnvs
Set ?device={device} when changing tab in installation guides (vllm…
915fdce 
…-project#12560)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Srikanth Srinivas <srikanth@astrum.ai>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
@hmellor @NickLucche
Set ?device={device} when changing tab in installation guides (vllm…
a6d053c 
…-project#12560)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
@hmellor @ShangmingCai
Set ?device={device} when changing tab in installation guides (vllm…
ac19233 
…-project#12560)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
@hmellor @GWS0428
Set ?device={device} when changing tab in installation guides (vllm…
2f0ad3f 
…-project#12560)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmellor @mgoin @simon-mo