[Misc] Fix improper placement of SPDX header in scripts #12694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a file starts with '#!', the SPDX header needs to go after that. When looking for the SPDX header, find it on any line, not just the first. Finally, don't add an extra newline when injecting the header into a file. Signed-off-by: Russell Bryant <rbryant@redhat.com>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
DarkLight1337
approved these changes
Feb 3, 2025
|
Thanks for fixing! |
github-actions
bot
added
the
ready
mgoin
approved these changes
Feb 3, 2025
tlrmchlsmth
approved these changes
Feb 3, 2025
khluu
approved these changes
Feb 3, 2025
fxmarty-amd
pushed a commit
to fxmarty-amd/vllm
that referenced
this pull request
Feb 7, 2025
…#12694) Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Felix Marty <felmarty@amd.com>
ShangmingCai
pushed a commit
to ShangmingCai/vllm
that referenced
this pull request
Feb 10, 2025
…#12694) Signed-off-by: Russell Bryant <rbryant@redhat.com>
panf2333
pushed a commit
to yottalabsai/vllm
that referenced
this pull request
Feb 18, 2025
…#12694) Signed-off-by: Russell Bryant <rbryant@redhat.com>
kerthcet
pushed a commit
to kerthcet/vllm
that referenced
this pull request
Feb 21, 2025
…#12694) Signed-off-by: Russell Bryant <rbryant@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file starts with '#!', the SPDX header needs to go after that.
When looking for the SPDX header, find it on any line, not just the
first.
Finally, don't add an extra newline when injecting the header into a
file.
Signed-off-by: Russell Bryant rbryant@redhat.com