Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix Qwen2_5_VLForConditionalGeneration packed_modules_mapping #12905

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Feb 7, 2025

There are issues with packed_modules_mapping, which is causing problems with BNB.
FIX #12900
FIX #12902

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link

github-actions bot commented Feb 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 7, 2025
@MotorBottle MotorBottle mentioned this pull request Feb 7, 2025
4 tasks
@simon-mo simon-mo merged commit 306923d into vllm-project:main Feb 8, 2025
56 of 63 checks passed
SzymonOzog pushed a commit to SzymonOzog/vllm that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
3 participants