Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] add extra_args to SamplingParams #13300

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akeshet
Copy link
Contributor

@akeshet akeshet commented Feb 14, 2025

This PR adds an extra_args field to SamplingParams, for use by custom (out-of-tree) sampling implementations.

Signed-off-by: Aviv Keshet <akeshet@scaledcognition.com>
@akeshet akeshet marked this pull request as ready for review February 14, 2025 17:52
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@wangxiyuan wangxiyuan mentioned this pull request Feb 17, 2025
1 task
@NickLucche
Copy link
Contributor

Looks like pre-commit needs to be run here

Signed-off-by: Aviv Keshet <akeshet@scaledcognition.com>
@akeshet
Copy link
Contributor Author

akeshet commented Feb 21, 2025

Looks like pre-commit needs to be run here

Fixed manually, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants