Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VLM] Check required fields before initializing field config in DictEmbeddingItems #13380

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

DarkLight1337
Copy link
Member

Since field config can depend on some required fields, this PR runs the required fields check first to provide a more informative error message.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 17, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 17, 2025
@DarkLight1337 DarkLight1337 changed the title [VLM] Check required fields before initializing field config [VLM] Check required fields before initializing field config in DictEmbeddingItems Feb 17, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 17, 2025 06:59
@simon-mo simon-mo merged commit 7b623fc into vllm-project:main Feb 17, 2025
43 of 46 checks passed
@DarkLight1337 DarkLight1337 deleted the dict-fields-factory branch February 17, 2025 09:36
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants