Skip to content

[Bugfix] : Prompt logprobs clean #13406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Bugfix] : Prompt logprobs clean #13406

wants to merge 4 commits into from

Conversation

@maxDavid40
Copy link

@maxDavid40 maxDavid40 commented Feb 17, 2025 •
edited by github-actions bot
Loading

Factorize clean prompt_logprobs method from #11073 to be also used in serving_chat to avoid JSONResponse's error

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 17, 2025
@maxDavid40
Fix docstring prompt_logprobs default value
bffb799 
Signed-off-by: maxDavid40 <maxdavid40@gmail.com>
@maxDavid40
create static method to clean prompt_logprobs
ee09046 
Signed-off-by: maxDavid40 <maxdavid40@gmail.com>
@maxDavid40
use static method to clean prompt logprobs
ba195f5 
Signed-off-by: maxDavid40 <maxdavid40@gmail.com>
@maxDavid40 maxDavid40 force-pushed the prompt_logprobs_clean branch from 9cdd1ac to ba195f5 Compare February 17, 2025 14:02
njhill
njhill reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @maxDavid40, could you revert that doc change?

@maxDavid40 maxDavid40 force-pushed the prompt_logprobs_clean branch from f57cb47 to 49e2f4b Compare February 18, 2025 09:25
@maxDavid40
Fix docstring mistake
334a6f1 
Signed-off-by: maxDavid40 <maxdavid40@gmail.com>
@maxDavid40 maxDavid40 force-pushed the prompt_logprobs_clean branch from 49e2f4b to 334a6f1 Compare February 18, 2025 09:28
@WoosukKwon WoosukKwon requested a review from njhill February 18, 2025 21:19
@maxDavid40
Copy link
Author

maxDavid40 commented Mar 6, 2025

@njhill Is it good for you ?

@njhill
Copy link
Member

njhill commented Mar 6, 2025

@maxDavid40 I'm really sorry, I completely forgot about this PR, and in the meantime this was fixed by #14225 (basically exactly the same changes as yours). Sorry again about this, I worry about my memory sometimes 🙃

@maxDavid40 maxDavid40 closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njhill njhill Awaiting requested review from njhill

Assignees

No one assigned

Labels

frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxDavid40 @njhill