Skip to content

Conversation

@WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Feb 18, 2025

It turns out that TP + PP in V1 does not work with Ray 2.41.0 for some reason. 2.40.0 works though.

Just for a record, I got the following error on 2.41.0:

EngineCore hit an exception: Traceback (most recent call last):
ERROR 02-18 01:08:08 core.py:283]   File "/data/woosuk/workspace/vllm/vllm/v1/engine/core.py", line 276, in run_engine_core
ERROR 02-18 01:08:08 core.py:283]     engine_core.run_busy_loop()
ERROR 02-18 01:08:08 core.py:283]   File "/data/woosuk/workspace/vllm/vllm/v1/engine/core.py", line 319, in run_busy_loop
ERROR 02-18 01:08:08 core.py:283]     outputs = step_fn()
ERROR 02-18 01:08:08 core.py:283]               ^^^^^^^^^
ERROR 02-18 01:08:08 core.py:283]   File "/data/woosuk/workspace/vllm/vllm/v1/engine/core.py", line 193, in step_with_batch_queue
ERROR 02-18 01:08:08 core.py:283]     model_output = future.result()
ERROR 02-18 01:08:08 core.py:283]                    ^^^^^^^^^^^^^^^
ERROR 02-18 01:08:08 core.py:283]   File "/data/woosuk/workspace/vllm/vllm/v1/executor/ray_distributed_executor.py", line 24, in result
ERROR 02-18 01:08:08 core.py:283]     return self.ref.get()
ERROR 02-18 01:08:08 core.py:283]            ^^^^^^^^^^^^^^
ERROR 02-18 01:08:08 core.py:283]   File "/data/woosuk/miniconda3/envs/vllm-py311/lib/python3.11/site-packages/ray/experimental/compiled_dag_ref.py", line 115, in get
ERROR 02-18 01:08:08 core.py:283]     return_vals = self._dag._execute_until(
ERROR 02-18 01:08:08 core.py:283]                   ^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 02-18 01:08:08 core.py:283]   File "/data/woosuk/miniconda3/envs/vllm-py311/lib/python3.11/site-packages/ray/dag/compiled_dag_node.py", line 2074, in _execute_until
ERROR 02-18 01:08:08 core.py:283]     return self._get_execution_results(execution_index, channel_index)
ERROR 02-18 01:08:08 core.py:283]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 02-18 01:08:08 core.py:283]   File "/data/woosuk/miniconda3/envs/vllm-py311/lib/python3.11/site-packages/ray/dag/compiled_dag_node.py", line 1982, in _get_execution_results
ERROR 02-18 01:08:08 core.py:283]     assert execution_index in self._result_buffer
ERROR 02-18 01:08:08 core.py:283]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 02-18 01:08:08 core.py:283] AssertionError

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@comaniac comaniac enabled auto-merge (squash) February 18, 2025 17:39
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
@WoosukKwon WoosukKwon disabled auto-merge February 18, 2025 20:50
@WoosukKwon WoosukKwon merged commit c8d70e2 into main Feb 18, 2025
87 of 89 checks passed
@WoosukKwon WoosukKwon deleted the ray-pp-version branch February 18, 2025 20:50
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@anrooo
Copy link

anrooo commented Mar 3, 2025

Hey, did you have any additional context here? We're getting blocked on this incompatibility as we needed some of the other bug fixes in Ray 2.41 and looking for a solution.

@comaniac
Copy link
Collaborator

comaniac commented Mar 3, 2025

This PR is merged: #13994

lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants