-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VLM][Bugfix] Pass processor kwargs properly on init #13516
[VLM][Bugfix] Pass processor kwargs properly on init #13516
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
fd494f6
to
dbde318
Compare
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This PR fixes an issue where multi-modal processors using custom HF processors failed to be initialized with kwargs from
model_config.mm_processor_kwargs
. I added theinit_processor
method toInputContext
to help ensure that those kwargs are being forwarded correctly.To avoid regressions, all model-specific processor tests now check that the result is the same regardless of whether the kwargs are passed during initialization or during inference (see
kwargs_on_init
param).Other changes/fixes:
build_model_context
.cached_xxx_from_config
convenience methods for constructing HF tokenizers and processors frommodel_config
.cached_get_xxx
convenience methods tovllm.transformers_utils.tokenizer
andvllm.transformers_utils.processor
.min_dynamic_patch
for InternVL-based models.