-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Bugfix][CPU] Fix cpu all-reduce using native pytorch implementation #13586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
youkaichao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix!
|
Unblocked CPU tests, we can merge if it passes |
|
@khluu I think we need to update CPU CI with AWS creds as well? |
|
Meanwhile let's just merge this |
…llm-project#13586) Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
ipex.distributed,all_reduceimplementation fromtorch.distributedwon't return all-reduced tensor:https://github.com/pytorch/pytorch/blob/0b0da81021e061c021e515bc35d7dc0dbbb05941/torch/distributed/distributed_c10d.py#L2753-L2755