Skip to content

Conversation

@qli88
Copy link
Contributor

@qli88 qli88 commented Feb 21, 2025

[MISC] enable users to select Triton FA for MLA backend

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: qli88 <qiang.li2@amd.com>
@hongxiayang hongxiayang added the rocm Related to AMD ROCm label Feb 22, 2025
@mergify
Copy link

mergify bot commented Feb 22, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @qli88.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 22, 2025
@qli88 qli88 closed this Feb 23, 2025
@houseroad
Copy link
Collaborator

Btw, why close this one?

@qli88
Copy link
Contributor Author

qli88 commented Feb 27, 2025

A new PR broke this again. It is now in #13718 and got approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants