Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] fix: test metric tag setting #13717

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −3
Open

[CI/CD] fix: test metric tag setting #13717

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0f62a6
fix: test metric tag setting
llsj14 Feb 23, 2025
84cdb4f
Merge remote-tracking branch 'upstream/main' into fix/test-metrics
llsj14 Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/metrics/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,10 @@ def test_metric_set_tag_model_name(vllm_runner, model: str, dtype: str,
metrics_tag_content = stat_logger.labels["model_name"]

if served_model_name is None or served_model_name == []:
assert metrics_tag_content == f"{MODEL_WEIGHTS_S3_BUCKET}/{model}", (
f"Metrics tag model_name is wrong! expect: {model!r}\n"
f"actual: {metrics_tag_content!r}")
assert (f"{MODEL_WEIGHTS_S3_BUCKET}/{metrics_tag_content}" ==
f"{MODEL_WEIGHTS_S3_BUCKET}/{model}"), (
f"Metrics tag model_name is wrong! expect: {model!r}\n"
f"actual: {metrics_tag_content!r}")
else:
assert metrics_tag_content == served_model_name[0], (
f"Metrics tag model_name is wrong! expect: "
Expand Down