-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[V1][Spec Decode] Change Spec Decode Rejection Sampling API #13729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ject#13729) Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
This PR tries to change the API of rejection sampler of speculative decoding. This is the preliminary step to support random sampling.
Tasks outside the scope of this PR.
draft_token_idsto persistent batch, which can avoid list operations to convert tensor.