Skip to content

[Bugfix] Handle None parameters in Mistral function calls. #13786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

[Bugfix] Handle None parameters in Mistral function calls. #13786

merged 1 commit into from
Feb 26, 2025

Conversation

@fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Feb 24, 2025 •
edited by github-actions bot
Loading

This is a follow-up of #12884 which was missing the case when a client explicitly passes None function parameters. While not super useful this is technically valid and should also be allowed.

⚒️ with ❤️ by @siemens

@github-actions
Copy link

github-actions bot commented Feb 24, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@fgreinacher fgreinacher marked this pull request as ready for review February 24, 2025 21:13
@fgreinacher
Copy link
Contributor Author

fgreinacher commented Feb 24, 2025

@DarkLight1337 As you have reviewed the previous PR would you be so kind to also have a look at this one? 🙇

/cc @bufferoverflow

mgoin
mgoin approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me - thank you for the contribution

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
@mgoin mgoin enabled auto-merge (squash) February 24, 2025 21:50
@fgreinacher
Copy link
Contributor Author

fgreinacher commented Feb 25, 2025 •
edited
Loading

Thanks @mgoin! I had a look at the failing checks and they seem unrelated to the changes here. Can you have a quick look and re-trigger them? 🙇

@mgoin
Copy link
Member

mgoin commented Feb 25, 2025

Yup we have flakey tests at the moment. Retrying now!

@fgreinacher
Copy link
Contributor Author

fgreinacher commented Feb 25, 2025

Yup we have flakey tests at the moment. Retrying now!

Thanks @mgoin! Not much improvement unfortunately 😢

@mgoin
Copy link
Member

mgoin commented Feb 25, 2025

@fgreinacher It looks like the engine test is a real failure https://buildkite.com/vllm/ci/builds/14086#01953d3c-62f4-4051-8829-ccc94dd06c09/207-1647

@fgreinacher
[Bugfix] Handle None parameters in Mistral function calls.
72f255e 
Signed-off-by: Florian Greinacher <florian.greinacher@siemens.com>
auto-merge was automatically disabled February 25, 2025 20:23

Head branch was pushed to by a user without write access

@fgreinacher fgreinacher force-pushed the fix/mistral-tokenizer branch from 55c5953 to 72f255e Compare February 25, 2025 20:23
@fgreinacher
Copy link
Contributor Author

fgreinacher commented Feb 26, 2025

Thanks @mgoin, there was indeed a problem with the new test case. This is fixed now and the remaining failures really look unrelated now 😀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 26, 2025 11:06
@vllm-bot vllm-bot merged commit 215bf15 into vllm-project:main Feb 26, 2025
41 of 43 checks passed
@fgreinacher fgreinacher deleted the fix/mistral-tokenizer branch February 26, 2025 13:51
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@fgreinacher @Akshat-Tripathi
[Bugfix] Handle None parameters in Mistral function calls. (vllm-proj…
71fa6b5 
…ect#13786)
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@fgreinacher @lulmer
[Bugfix] Handle None parameters in Mistral function calls. (vllm-proj…
ab86969 
…ect#13786)

Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@fgreinacher @shreyankg
[Bugfix] Handle None parameters in Mistral function calls. (vllm-proj…
dcb969a 
…ect#13786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fgreinacher @mgoin @vllm-bot