Skip to content

[BugFix] Make FP8 Linear compatible with torch.compile #13918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2025
Merged

[BugFix] Make FP8 Linear compatible with torch.compile #13918

merged 2 commits into from
Feb 26, 2025

Conversation

@WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Feb 26, 2025 •
edited
Loading

This PR registers the FP8 block linear op for torch.compile

@WoosukKwon
[BugFix] Make FP8 Linear compatible with torch.compile
541fe06 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

mgoin
mgoin approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlrmchlsmth @LucasWilkinson

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 26, 2025
@WoosukKwon
Copy link
Collaborator Author

WoosukKwon commented Feb 26, 2025 •
edited
Loading

*This PR is not tested yet. Tested by @chenyang78

chenyang78
chenyang78 reviewed Feb 26, 2025
View reviewed changes
@WoosukKwon
Fix
f113803 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon WoosukKwon merged commit b382a7f into main Feb 26, 2025
12 of 16 checks passed
@WoosukKwon WoosukKwon deleted the fp8-linear-torch-compile branch February 26, 2025 21:48
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@WoosukKwon @Akshat-Tripathi
[BugFix] Make FP8 Linear compatible with torch.compile (vllm-project#…
5eb0d63 
…13918)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@WoosukKwon @lulmer
[BugFix] Make FP8 Linear compatible with torch.compile (vllm-project#…
00be88b 
…13918)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@WoosukKwon @shreyankg
[BugFix] Make FP8 Linear compatible with torch.compile (vllm-project#…
8418a34 
…13918)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@ProExpertProg
Copy link
Collaborator

Does anyone remember why this was necessary? It's getting in the way of fusion so we want to unwrap it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

+1 more reviewer

@chenyang78 chenyang78 chenyang78 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WoosukKwon @ProExpertProg @chenyang78 @mgoin