Skip to content

[Bugfix] Fix MoeWNA16Method activation #14024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

[Bugfix] Fix MoeWNA16Method activation #14024

merged 1 commit into from
Feb 28, 2025

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Feb 28, 2025 •
edited by github-actions bot
Loading

No description provided.

@jeejeelee
Done
4041bf5 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@github-actions
Copy link

github-actions bot commented Feb 28, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed bug Something isn't working labels Feb 28, 2025
@mgoin mgoin enabled auto-merge (squash) February 28, 2025 14:02
@mgoin mgoin merged commit e073438 into vllm-project:main Feb 28, 2025
53 checks passed
@jeejeelee jeejeelee deleted the fix-moewna16-act branch February 28, 2025 17:06
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@jeejeelee @Akshat-Tripathi
[Bugfix] Fix MoeWNA16Method activation (vllm-project#14024)
367db4b
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@jeejeelee @lulmer
[Bugfix] Fix MoeWNA16Method activation (vllm-project#14024)
74a435d 
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@jeejeelee @shreyankg
[Bugfix] Fix MoeWNA16Method activation (vllm-project#14024)
7949fc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

Assignees

No one assigned

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeejeelee @mgoin