Skip to content

[Doc] Fix ROCm documentation #14041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

[Doc] Fix ROCm documentation #14041

merged 1 commit into from
Feb 28, 2025

Conversation

@b8zhong
Copy link
Contributor

@b8zhong b8zhong commented Feb 28, 2025 •
edited by github-actions bot
Loading

Quick fix for links pointing to deleted branches.

FIX #14029

@b8zhong
fix url for ROCm
3e379da 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
@github-actions
Copy link

github-actions bot commented Feb 28, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 28, 2025
hmellor
hmellor approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@hmellor hmellor enabled auto-merge (squash) February 28, 2025 14:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 28, 2025
@hmellor hmellor merged commit 2aed2c9 into vllm-project:main Feb 28, 2025
30 of 32 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@b8zhong @Akshat-Tripathi
[Doc] Fix ROCm documentation (vllm-project#14041)
e613446 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@b8zhong @lulmer
[Doc] Fix ROCm documentation (vllm-project#14041)
17bbd9b 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@b8zhong @shreyankg
[Doc] Fix ROCm documentation (vllm-project#14041)
a8c1a44 
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmellor hmellor hmellor approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Doc]: Invalid Links in rocm.inc.md

2 participants

@b8zhong @hmellor