Skip to content

Conversation

@bigPYJ1151
Copy link
Member

@bigPYJ1151 bigPYJ1151 commented Feb 28, 2025

I noticed the checking for shutting_down flag in V1 MultiprocExecutor will always be False, and it ignores _ensure_worker_termination for terminating worker processes gracefully in some situations.

This PR fixed it.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: jiang1.li <jiang1.li@intel.com>
@bigPYJ1151
Copy link
Member Author

Hi @tlrmchlsmth, can you help to review this fix? I think you are the author of the v1 MP executor, thanks :)

Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) February 28, 2025 17:20
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 28, 2025
@vllm-bot vllm-bot merged commit 02296f4 into vllm-project:main Mar 1, 2025
43 of 47 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…ecutor (vllm-project#14053)

Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants