Skip to content

[ROCm][V1][Bugfix] Add get_builder_cls method to the ROCmAttentionBackend class #14065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

[ROCm][V1][Bugfix] Add get_builder_cls method to the ROCmAttentionBackend class #14065

merged 1 commit into from
Mar 1, 2025

Conversation

@SageMoore
Copy link
Contributor

@SageMoore SageMoore commented Feb 28, 2025 •
edited by github-actions bot
Loading

The ROCmAttentionBackend currently just uses the FlashAttentionMetadata so it can use the FlashAttentionMetadataBuilder. This PR is required now that the V1 GPUModelRunner supports other meta data structures.

@SageMoore
init
e698f86 
Signed-off-by: Sage Moore <sage@neuralmagic.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@SageMoore SageMoore changed the title Add get_builder_cls method to the ROCmAttentionBackend class [ROCm][V1][Bugfix] Add get_builder_cls method to the ROCmAttentionBackend class Feb 28, 2025
@mergify mergify bot added the v1 label Feb 28, 2025
@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 28, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) February 28, 2025 20:59
maleksan85
maleksan85 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@maleksan85 maleksan85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks!

@tlrmchlsmth tlrmchlsmth merged commit b28246f into vllm-project:main Mar 1, 2025
49 of 51 checks passed
@SageMoore SageMoore deleted the sage/v1-rocm-attn-fix branch March 3, 2025 15:17
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@SageMoore @Akshat-Tripathi
[ROCm][V1][Bugfix] Add get_builder_cls method to the ROCmAttentionBac…
2658c53 
…kend class (vllm-project#14065)

Signed-off-by: Sage Moore <sage@neuralmagic.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@SageMoore @lulmer
[ROCm][V1][Bugfix] Add get_builder_cls method to the ROCmAttentionBac…
6faac8d 
…kend class (vllm-project#14065)

Signed-off-by: Sage Moore <sage@neuralmagic.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@SageMoore @shreyankg
[ROCm][V1][Bugfix] Add get_builder_cls method to the ROCmAttentionBac…
9b28cb6 
…kend class (vllm-project#14065)

Signed-off-by: Sage Moore <sage@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@ProExpertProg ProExpertProg ProExpertProg approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

+1 more reviewer

@maleksan85 maleksan85 maleksan85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SageMoore @tlrmchlsmth @ProExpertProg @maleksan85