-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[ROCm] Enable chunked prefill/paged attention in MLA on ROCm #14316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Enable chunked prefill/paged attention in MLA on ROCm #14316
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
vincent-4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts?
Signed-off-by: Sage Moore <sage@neuralmagic.com>
|
Nice! Thank you - cc @mawong-amd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. The changes are only applied to hip, and straightforward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
…oject#14316) Signed-off-by: Sage Moore <sage@neuralmagic.com> Signed-off-by: Richard Liu <ricliu@google.com>
…oject#14316) Signed-off-by: Sage Moore <sage@neuralmagic.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
…oject#14316) Signed-off-by: Sage Moore <sage@neuralmagic.com>
…oject#14316) Signed-off-by: Sage Moore <sage@neuralmagic.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
This PR is largely just removing the guards in config.py to allow chunked prefill and paged attention in MLA. The LSE computation in the triton kernel doesn't work so we always fall back to flash attention in this case.
I ran
lm_eval --model vllm --model_args pretrained=deepseek-ai/DeepSeek-Coder-V2-Lite-Instruct,trust_remote_code=True,enable_chunked_prefill=True --tasks gsm8k --num_fewshot 5 --batch_size autoand gotCC: @LucasWilkinson