-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Config][Disaggregated] Add timeout configuration for the torch.store and add KVTransferConfig.kv_connector_extra_config #14367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Config][Disaggregated] Add timeout configuration for the torch.store and add KVTransferConfig.kv_connector_extra_config #14367
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
1d0c332 to
c7d61de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small naming changes and other parts LGTM. Feel free to suggest other naming.
… KVTransferConfig.kv_connector_extra_config Signed-off-by: Mathis Felardos <mathis@mistral.ai>
c7d61de to
cefd6d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… and add KVTransferConfig.kv_connector_extra_config (vllm-project#14367) Signed-off-by: Mathis Felardos <mathis@mistral.ai> Signed-off-by: Richard Liu <ricliu@google.com>
… and add KVTransferConfig.kv_connector_extra_config (vllm-project#14367) Signed-off-by: Mathis Felardos <mathis@mistral.ai> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
… and add KVTransferConfig.kv_connector_extra_config (vllm-project#14367) Signed-off-by: Mathis Felardos <mathis@mistral.ai>
… and add KVTransferConfig.kv_connector_extra_config (vllm-project#14367) Signed-off-by: Mathis Felardos <mathis@mistral.ai> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Hello,
Adding a kv_connector_extra_config will help custom connectors to use it to hack around if they need.
I'm using it within the SimpleBuffer/PyNcclPipe to set the
torch.distributedStore's timeout (in the example, I set the timeout for 1 hour):Issue like this: #10502 (comment)
torch.distributed.DistStoreError: wait timeout after 300000ms, keys: /send_to/0/4Would happen less frequently, since it only happen when you have no requests.
I think it's not safe to increase it too much, but I have been able to increase this safely to more than 1 hour. It can be useful for dev purposes, or to reduce the need of a frequent heartbeat.