-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[Misc] Fix test_sleep to use query parameters #14373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lize Cai <lize.cai@sap.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
@youkaichao can you help to review this? which is the correct way to change the level? in the query parameter or the request body, thanks. |
|
you can take a look at the server log. |
Hi @youkaichao, In the implementation, it is using query params but in the tests it is tested by data. This PR try to fix the test to align with the implementation and add a test on other sleep levels. |
Signed-off-by: youkaichao <youkaichao@gmail.com>
youkaichao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix! this is indeed a bug in the test. we don't need to add more tests, #15500 will add new tests.
Signed-off-by: Lize Cai <lize.cai@sap.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com> Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
Signed-off-by: Lize Cai <lize.cai@sap.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: Lize Cai <lize.cai@sap.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Lize Cai <lize.cai@sap.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Lize Cai <lize.cai@sap.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
try to follow the test to try out the sleep feature but failed to set other levels. test_sleep should use
paramsinstead ofdataas defined in the implementation.