Skip to content

Conversation

@lizzzcai
Copy link
Contributor

@lizzzcai lizzzcai commented Mar 6, 2025

try to follow the test to try out the sleep feature but failed to set other levels. test_sleep should use params instead of data as defined in the implementation.

Signed-off-by: Lize Cai <lize.cai@sap.com>
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@lizzzcai lizzzcai changed the title Fix test_sleep to use query parameters [Misc] Fix test_sleep to use query parameters Mar 6, 2025
@lizzzcai
Copy link
Contributor Author

lizzzcai commented Mar 19, 2025

@youkaichao can you help to review this? which is the correct way to change the level? in the query parameter or the request body, thanks.

@youkaichao
Copy link
Member

you can take a look at the server log.

@lizzzcai
Copy link
Contributor Author

lizzzcai commented Mar 22, 2025

you can take a look at the server log.

Hi @youkaichao, In the implementation, it is using query params but in the tests it is tested by data. This PR try to fix the test to align with the implementation and add a test on other sleep levels.

Signed-off-by: youkaichao <youkaichao@gmail.com>
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! this is indeed a bug in the test. we don't need to add more tests, #15500 will add new tests.

@youkaichao youkaichao merged commit a10314c into vllm-project:main Mar 28, 2025
5 of 8 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@lizzzcai lizzzcai deleted the fix-test_sleep-0306 branch June 8, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants