Skip to content

[Misc] Refactor platform to get device specific stream and event #14411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

[Misc] Refactor platform to get device specific stream and event #14411

merged 1 commit into from
Apr 21, 2025

Conversation

@shen-shanshan
Copy link
Contributor

@shen-shanshan shen-shanshan commented Mar 7, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Add a __getitem__ method for Platform class.

When using cuda, current_platform['xxx'] is equal to torch.cuda.xxx, whereas when using npu, current_platform['xxx'] is equal to torch.npu.xxx. Thus, we do not need to abstract Stream or Event anymore.

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@shen-shanshan shen-shanshan changed the title [Misc] format [Misc] Add get_stream_cls() method for Platform class Mar 7, 2025
@shen-shanshan shen-shanshan mentioned this pull request Mar 7, 2025
Closed
@wangxiyuan wangxiyuan mentioned this pull request Mar 7, 2025
Closed
1 task
@Selkh
Copy link

Selkh commented Mar 15, 2025

There 're also some "torch.cuda.Stream"s in vllm/distributed/parallel_state.py:graph_capture

@shen-shanshan shen-shanshan changed the title [Misc] Add get_stream_cls() method for Platform class [Misc] Refactor platform to get device specific stream and event Mar 19, 2025
youkaichao
youkaichao reviewed Mar 22, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't create abstractions until many platforms need this.

@shen-shanshan shen-shanshan reopened this Apr 14, 2025
@mergify
Copy link

mergify bot commented Apr 14, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @shen-shanshan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 14, 2025
wangxiyuan
wangxiyuan reviewed Apr 14, 2025
View reviewed changes
@shen-shanshan
update
0386180 
Signed-off-by: shen-shanshan <467638484@qq.com>
@mergify mergify bot removed the needs-rebase label Apr 15, 2025
@shen-shanshan
Copy link
Contributor Author

@youkaichao I have updated a new version for this refactor. By directly adding __getattr__() method to Platform, all kinds of hardware can get their Stream, Event or other attribute without modification to vllm. I think this can make vllm more extensible. 😄

youkaichao
youkaichao approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, this looks better.

@youkaichao youkaichao merged commit 7272bfa into vllm-project:main Apr 21, 2025
21 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@shen-shanshan @yangw-dev
[Misc] Refactor platform to get device specific stream and event (vll…
6cd3ec6 
…m-project#14411)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
@shen-shanshan shen-shanshan mentioned this pull request Apr 22, 2025
Merged
wangxiyuan pushed a commit to vllm-project/vllm-ascend that referenced this pull request Apr 22, 2025
@shen-shanshan
[Misc] Remove some parts of metrics patch (#603)
4a0ce36 
### What this PR does / why we need it?
Remove some parts of metrics patch, since the `cuda` hard code has been
fixed by vllm-project/vllm#14411.

Signed-off-by: shen-shanshan <467638484@qq.com>
@shen-shanshan shen-shanshan mentioned this pull request Apr 22, 2025
Merged
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
@shen-shanshan @frieda-huang
[Misc] Refactor platform to get device specific stream and event (vll…
bb62580 
…m-project#14411)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Frieda (Jingying) Huang <jingyingfhuang@gmail.com>
ttanzhiqiang pushed a commit to ttanzhiqiang/vllm-ascend that referenced this pull request Apr 27, 2025
@shen-shanshan
[Misc] Remove some parts of metrics patch (vllm-project#603)
8c20dc3 
### What this PR does / why we need it?
Remove some parts of metrics patch, since the `cuda` hard code has been
fixed by vllm-project/vllm#14411.

Signed-off-by: shen-shanshan <467638484@qq.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@shen-shanshan @dbyoung18
[Misc] Refactor platform to get device specific stream and event (vll…
bd02fff 
…m-project#14411)

Signed-off-by: shen-shanshan <467638484@qq.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@shen-shanshan @lk-chen
[Misc] Refactor platform to get device specific stream and event (vll…
5fc6c04 
…m-project#14411)

Signed-off-by: shen-shanshan <467638484@qq.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@shen-shanshan @adobrzyn
[Misc] Refactor platform to get device specific stream and event (vll…
cc14657 
…m-project#14411)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@shen-shanshan
[Misc] Refactor platform to get device specific stream and event (vll…
60be22e 
…m-project#14411)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
@aarnphm aarnphm mentioned this pull request May 28, 2025
Open
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
@shen-shanshan @Angazenn
[Misc] Remove some parts of metrics patch (vllm-project#603)
0cd5828 
### What this PR does / why we need it?
Remove some parts of metrics patch, since the `cuda` hard code has been
fixed by vllm-project/vllm#14411.

Signed-off-by: shen-shanshan <467638484@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youkaichao youkaichao youkaichao approved these changes

+1 more reviewer

@wangxiyuan wangxiyuan wangxiyuan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

speculative-decoding

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shen-shanshan @Selkh @wangxiyuan @youkaichao