Skip to content

Conversation

@yarongmu-google
Copy link
Contributor

@yarongmu-google yarongmu-google commented Mar 9, 2025

…274 for V0 (V1 was fixed earlier)

FIX #14274

@github-actions
Copy link

github-actions bot commented Mar 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@mergify mergify bot added the v1 label Mar 14, 2025
@khluu
Copy link
Collaborator

khluu commented Mar 14, 2025

Can you help fix the precommit errors here: https://github.com/vllm-project/vllm/actions/runs/13847341623/job/38748379763?pr=14520#step:6:1432
You can also setup precommit so it runs whenever you commit to branch: https://docs.vllm.ai/en/latest/contributing/overview.html#testing

@mergify mergify bot added the ci/build label Mar 14, 2025
@yarongmu-google yarongmu-google force-pushed the feature/fix-model-config-seed-default-none-introduced-in-14274 branch from 0cc997c to 4290b70 Compare March 14, 2025 20:53
@yarongmu-google yarongmu-google deleted the feature/fix-model-config-seed-default-none-introduced-in-14274 branch March 16, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants