Skip to content

Conversation

@richardsliu
Copy link
Contributor

Uninstall torch, torch_xla and torch_vision before installing from requirements/tpu.txt to prevent version conflicts.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by:  <ricliu@google.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Copy link
Collaborator

@alexm-redhat alexm-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexm-redhat alexm-redhat enabled auto-merge (squash) March 11, 2025 14:10
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 11, 2025
@vllm-bot vllm-bot merged commit 9ab3267 into vllm-project:main Mar 11, 2025
55 of 70 checks passed
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Mar 11, 2025
…roject#14586)

Signed-off-by: <ricliu@google.com>
Signed-off-by: Richard Liu <ricliu@google.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…roject#14586)

Signed-off-by: <ricliu@google.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
…roject#14586)

Signed-off-by: <ricliu@google.com>
Signed-off-by: Richard Liu <ricliu@google.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…roject#14586)

Signed-off-by: <ricliu@google.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@tvalentyn
Copy link
Contributor

note that the content of these dependencies, even if deleted, would still remain in the layers of the docker image as dead weight. it would be better to not have them in the first place, or have correct versions from the beginning.

@tvalentyn
Copy link
Contributor

(happened to look at this while investigating #23252 )

@tvalentyn
Copy link
Contributor

I wonder if you should use a different base image instead or see how the "us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/xla:nightly_3.12_tpuvm_$NIGHTLY_DATE" is built, and instead build entire image from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants