-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Uninstall dependencies before installing requirements/tpu.txt #14586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: <ricliu@google.com> Signed-off-by: Richard Liu <ricliu@google.com>
alexm-redhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…roject#14586) Signed-off-by: <ricliu@google.com> Signed-off-by: Richard Liu <ricliu@google.com>
…roject#14586) Signed-off-by: <ricliu@google.com> Signed-off-by: Richard Liu <ricliu@google.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
…roject#14586) Signed-off-by: <ricliu@google.com> Signed-off-by: Richard Liu <ricliu@google.com>
…roject#14586) Signed-off-by: <ricliu@google.com> Signed-off-by: Richard Liu <ricliu@google.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
|
note that the content of these dependencies, even if deleted, would still remain in the layers of the docker image as dead weight. it would be better to not have them in the first place, or have correct versions from the beginning. |
|
(happened to look at this while investigating #23252 ) |
|
I wonder if you should use a different base image instead or see how the "us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/xla:nightly_3.12_tpuvm_$NIGHTLY_DATE" is built, and instead build entire image from scratch. |
Uninstall
torch,torch_xlaandtorch_visionbefore installing fromrequirements/tpu.txtto prevent version conflicts.