-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[V1] [CI] Enable v1/entrypoints
#14619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
russellb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
I wish I knew why spawn was required, but if this makes it work for now, fine with me
|
This pull request has merge conflicts that must be resolved before it can be |
I think it was because I ran on TP>1 locally. Will remove |
@markmc saw failures with TP=1 I think, but I wasn't able to reproduce |
|
See #14579 for the failure |
|
#14512 is required to fix |
Merged now, so can rebase onto it |
Still expecting Reproducer: |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
I get this error now: |
|
This is with @russellb 's latest commits merged in |
|
and I think the 2 PRs are duplicates? |
SUMMARY:
v1/entrypointstests