Skip to content

[V1][Core] Support MistralTokenizer for Structured Output #14625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

[V1][Core] Support MistralTokenizer for Structured Output #14625

merged 2 commits into from
Mar 12, 2025

Conversation

@aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Mar 11, 2025

Closes #14522

Signed-off-by: Aaron Pham contact@aarnphm.xyz

@aarnphm aarnphm requested review from mgoin and russellb as code owners March 11, 2025 16:27
@github-actions
Copy link

github-actions bot commented Mar 11, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@aarnphm aarnphm mentioned this pull request Mar 11, 2025
Closed
1 task
@mergify mergify bot added the v1 label Mar 11, 2025
@aarnphm aarnphm changed the title [V1][Core] Support MistralTokenizer for structured outputs [V1][Core] Support MistralTokenizer Mar 11, 2025
@aarnphm aarnphm force-pushed the v1/support-mistral branch from 762d864 to 6266e68 Compare March 11, 2025 16:32
@robertgshaw2-redhat
Copy link
Collaborator

robertgshaw2-redhat commented Mar 11, 2025

add a test! Thanks!

@aarnphm
Copy link
Collaborator Author

aarnphm commented Mar 11, 2025

add a test! Thanks!

Added 😃

@aarnphm aarnphm force-pushed the v1/support-mistral branch from a9a8e85 to bee86f2 Compare March 11, 2025 18:09
@aarnphm aarnphm mentioned this pull request Mar 11, 2025
Merged
@mergify
Copy link

mergify bot commented Mar 11, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 11, 2025
@WoosukKwon
Copy link
Collaborator

WoosukKwon commented Mar 11, 2025

@aarnphm Can you please rebase the PR?
@russellb Could you please review this PR?
Thanks!

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 11, 2025
@aarnphm
Copy link
Collaborator Author

aarnphm commented Mar 11, 2025

Fixed.

@mgoin mgoin changed the title [V1][Core] Support MistralTokenizer [V1][Core] Support MistralTokenizer for Structured Output Mar 11, 2025
mgoin
mgoin approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI! Please fix merge conflict first though

@aarnphm
Copy link
Collaborator Author

aarnphm commented Mar 11, 2025 •
edited
Loading

Oh is there new merge conflicts?

😔😔

Edit: i forgot to push :)

@aarnphm
feat: support mistral tokenizer in V1
48c2199 
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm force-pushed the v1/support-mistral branch from bee86f2 to 48c2199 Compare March 12, 2025 00:17
@mergify mergify bot removed the needs-rebase label Mar 12, 2025
@aarnphm
fix: correct bad merge
773093d 
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@DarkLight1337 DarkLight1337 merged commit 77a318b into vllm-project:main Mar 12, 2025
29 checks passed
@aarnphm aarnphm deleted the v1/support-mistral branch March 12, 2025 03:50
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
@aarnphm @richardsliu
[V1][Core] Support MistralTokenizer for Structured Output (vllm-proje…
d87ee5f 
…ct#14625)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Richard Liu <ricliu@google.com>
@hibukipanim
Copy link

hibukipanim commented Mar 26, 2025 •
edited
Loading

Hi @aarnphm,

this doesn't seem to work for us with vllm 0.8.2 which includes this PR.

opened an issue with details: #15551

@hibukipanim hibukipanim mentioned this pull request Mar 26, 2025
Closed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@aarnphm @lulmer
[V1][Core] Support MistralTokenizer for Structured Output (vllm-proje…
4cad5b9 
…ct#14625)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@aarnphm @shreyankg
[V1][Core] Support MistralTokenizer for Structured Output (vllm-proje…
46f3e7c 
…ct#14625)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@aarnphm
[V1][Core] Support MistralTokenizer for Structured Output (vllm-proje…
d405f15 
…ct#14625)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@russellb russellb Awaiting requested review from russellb russellb is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Usage]: [V1] Support MistralTokenizer on V1

6 participants

@aarnphm @robertgshaw2-redhat @WoosukKwon @hibukipanim @mgoin @DarkLight1337