Skip to content

[Bugfix] fix benchmark moe #14653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2025
Merged

[Bugfix] fix benchmark moe #14653

merged 3 commits into from
Mar 13, 2025

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Mar 12, 2025 •
edited by github-actions bot
Loading

Introduced by #14068

@jeejeelee
Done
a3dbd75 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee requested a review from mgoin March 12, 2025 03:58
@github-actions
Copy link

github-actions bot commented Mar 12, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

kylesayrs
kylesayrs reviewed Mar 13, 2025
View reviewed changes
@jeejeelee
Merge branch 'vllm-project:main' into fix-moe-benchmark
aa06d85
@jeejeelee
Revert
fc47c53 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 13, 2025
@jeejeelee jeejeelee merged commit a73122d into vllm-project:main Mar 13, 2025
24 of 26 checks passed
@jeejeelee jeejeelee deleted the fix-moe-benchmark branch March 13, 2025 08:12
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
@jeejeelee @richardsliu
[Bugfix] fix benchmark moe (vllm-project#14653)
5b93de4 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Richard Liu <ricliu@google.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@jeejeelee @lulmer
[Bugfix] fix benchmark moe (vllm-project#14653)
104c4ea 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@jeejeelee @shreyankg
[Bugfix] fix benchmark moe (vllm-project#14653)
8451e06 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@jeejeelee
[Bugfix] fix benchmark moe (vllm-project#14653)
5bf0fab 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

+1 more reviewer

@kylesayrs kylesayrs kylesayrs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeejeelee @mgoin @kylesayrs