Skip to content

Conversation

@SzymonOzog
Copy link
Contributor

@SzymonOzog SzymonOzog commented Mar 12, 2025

As described in the comment, in chunked prefill the input to logits processor can be of shape (0, hidden_size)

The way I'm fixing it now is a bit of a hack, open to suggestions for a better fix

Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
@Isotr0py Isotr0py enabled auto-merge (squash) March 13, 2025 05:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 13, 2025
@Isotr0py Isotr0py merged commit 55211b0 into vllm-project:main Mar 13, 2025
45 of 47 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
Signed-off-by: Richard Liu <ricliu@google.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants