-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[V1] Move OOM check into sampler run #14728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Roger Wang <ywang@roblox.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
This pull request has merge conflicts that must be resolved before it can be |
Co-authored-by: Simon Mo <simon.mo@hey.com>
|
FWIW - this is what it looks like when the OOM check triggers, which isn't too bad! |
Signed-off-by: Roger Wang <ywang@roblox.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Richard Liu <ricliu@google.com>
Signed-off-by: Roger Wang <ywang@roblox.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: Roger Wang <ywang@roblox.com> Co-authored-by: Simon Mo <simon.mo@hey.com>
Signed-off-by: Roger Wang <ywang@roblox.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Move the OOM check from model warmup into
_dummy_sampler_runsince OOM can also happen duringprofile_run.FIXES #12529