Skip to content

Conversation

@aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Mar 15, 2025

we will need to calculate vocab size eagerly, fixes #14826

Signed-off-by: Aaron Pham contact@aarnphm.xyz

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm requested review from mgoin and russellb as code owners March 15, 2025 03:53
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 15, 2025
@aarnphm aarnphm requested a review from WoosukKwon March 15, 2025 03:57
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 15, 2025
@WoosukKwon WoosukKwon enabled auto-merge (squash) March 15, 2025 04:23
@vllm-bot vllm-bot merged commit 4c7629c into vllm-project:main Mar 15, 2025
19 of 39 checks passed
@aarnphm aarnphm deleted the fix/vocab-size-compatibility-vision-text branch March 15, 2025 05:10
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants