Skip to content

Conversation

@MengqingCao
Copy link
Contributor

@MengqingCao MengqingCao commented Mar 21, 2025

fix llava processor.
fix #13690
cc @DarkLight1337

Signed-off-by: Mengqing Cao <cmq0113@163.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh the proper fix is to update the HF repo, but we can keep this for backwards compatibility

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 21, 2025 10:58
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 21, 2025
@MengqingCao
Copy link
Contributor Author

MengqingCao commented Mar 21, 2025 via email

@vllm-bot vllm-bot merged commit c21b99b into vllm-project:main Mar 21, 2025
41 of 45 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
Signed-off-by: Mengqing Cao <cmq0113@163.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Mengqing Cao <cmq0113@163.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: Mengqing Cao <cmq0113@163.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Mengqing Cao <cmq0113@163.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: unsupported operand type(s) for //: 'int' and 'NoneType'

3 participants