-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Bugfix][VLM] fix llava processor #15285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mengqing Cao <cmq0113@163.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh the proper fix is to update the HF repo, but we can keep this for backwards compatibility
|
Agree. Thanks for your review! And the repo on modelscope is not updated by the way. This pr also could keep the compatibility of modelscope
…---- Replied Message ----
| From | Cyrus ***@***.***> |
| Date | 03/21/2025 18:58 |
| To | ***@***.***> |
| Cc | Mengqing ***@***.***>***@***.***> |
| Subject | Re: [vllm-project/vllm] [Bugfix][VLM] fix llava processor (PR #15285) |
@DarkLight1337 approved this pull request.
Tbh the proper fix is to update the HF repo, but we can keep this for backwards compatibility
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Signed-off-by: Mengqing Cao <cmq0113@163.com>
Signed-off-by: Mengqing Cao <cmq0113@163.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: Mengqing Cao <cmq0113@163.com>
Signed-off-by: Mengqing Cao <cmq0113@163.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
fix llava processor.
fix #13690
cc @DarkLight1337