Skip to content

[ci/build] fix broken tests in LLM.collective_rpc #15350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2025
Merged

[ci/build] fix broken tests in LLM.collective_rpc #15350

merged 2 commits into from
Mar 23, 2025

Conversation

@youkaichao
Copy link
Member

the test is not run in #15324 , and it's broken since LLM.collective_rpc is broken in v1 right now.

@youkaichao
fix tests
0b8dd71 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 23, 2025
@youkaichao
Copy link
Member Author

the error is observed in https://buildkite.com/vllm/ci/builds/16070/steps?jid=0195c0d1-57c4-422e-9321-ec0b70e03f04

@youkaichao
remove extension test
237d7da 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao youkaichao merged commit f68cce8 into vllm-project:main Mar 23, 2025
13 checks passed
@youkaichao youkaichao deleted the fix_ci branch March 23, 2025 06:49
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@youkaichao @erictang000
[ci/build] fix broken tests in LLM.collective_rpc (vllm-project#15350)
64ba256 
Signed-off-by: youkaichao <youkaichao@gmail.com>
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@youkaichao @wrmedford
[ci/build] fix broken tests in LLM.collective_rpc (vllm-project#15350)
36afa78 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@youkaichao @lulmer
[ci/build] fix broken tests in LLM.collective_rpc (vllm-project#15350)
47e6b1e 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@youkaichao @lk-chen
[ci/build] fix broken tests in LLM.collective_rpc (vllm-project#15350)
db5f105 
Signed-off-by: youkaichao <youkaichao@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@youkaichao @shreyankg
[ci/build] fix broken tests in LLM.collective_rpc (vllm-project#15350)
c4eadf0 
Signed-off-by: youkaichao <youkaichao@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@youkaichao
[ci/build] fix broken tests in LLM.collective_rpc (vllm-project#15350)
c3bc7ad 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

Assignees

No one assigned

Labels

ci/build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youkaichao @DarkLight1337