Skip to content

[distributed] fix dp group #15355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

[distributed] fix dp group #15355

merged 1 commit into from
Mar 24, 2025

Conversation

@youkaichao
Copy link
Member

fix dp group broken by #14899

@youkaichao
fix dp group
fc38b85 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@youkaichao youkaichao mentioned this pull request Mar 23, 2025
Merged
@youkaichao youkaichao linked an issue Mar 23, 2025 that may be closed by this pull request
[Bug]: external_dp blocks normal DP group creation #15176
Closed
1 task
@youkaichao youkaichao mentioned this pull request Mar 23, 2025
Closed
1 task
hiyouga
hiyouga reviewed Mar 23, 2025
View reviewed changes
Copy link
Contributor

@hiyouga hiyouga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has no conflict with verl's functionality
image

houseroad
houseroad approved these changes Mar 23, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

tlrmchlsmth
tlrmchlsmth approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I think this code is more straightforward after the change as well

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 24, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) March 24, 2025 13:11
@tlrmchlsmth tlrmchlsmth merged commit 9606d57 into vllm-project:main Mar 24, 2025
48 checks passed
@youkaichao youkaichao deleted the fix_dp_group branch March 24, 2025 15:18
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@youkaichao @erictang000
[distributed] fix dp group (vllm-project#15355)
2854602 
Signed-off-by: youkaichao <youkaichao@gmail.com>
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@youkaichao @wrmedford
[distributed] fix dp group (vllm-project#15355)
ef2232e 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
@njhill njhill mentioned this pull request Mar 27, 2025
Closed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@youkaichao @lulmer
[distributed] fix dp group (vllm-project#15355)
c0d57bc 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@youkaichao @lk-chen
[distributed] fix dp group (vllm-project#15355)
67a20a1 
Signed-off-by: youkaichao <youkaichao@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@youkaichao @shreyankg
[distributed] fix dp group (vllm-project#15355)
e744473 
Signed-off-by: youkaichao <youkaichao@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@youkaichao
[distributed] fix dp group (vllm-project#15355)
ad67c9b 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@houseroad houseroad houseroad approved these changes

+1 more reviewer

@hiyouga hiyouga hiyouga left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: external_dp blocks normal DP group creation

4 participants

@youkaichao @tlrmchlsmth @hiyouga @houseroad