Skip to content

[V1][Minor] fix comments #15392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2025
Merged

[V1][Minor] fix comments #15392

merged 4 commits into from
Mar 24, 2025

Conversation

@Chen-0210
Copy link
Contributor

@Chen-0210 Chen-0210 commented Mar 24, 2025 •
edited by github-actions bot
Loading

  1. Fix the comments.

update sample
749e53f 
Signed-off-by: chenjincong <chenjincong@baidu.com>
@github-actions
Copy link

github-actions bot commented Mar 24, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 24, 2025
robertgshaw2-redhat
robertgshaw2-redhat reviewed Mar 24, 2025
View reviewed changes
@Chen-0210 Chen-0210 changed the title [V1][Minor] Use topk_logprobs and fix comments [V1][Minor] fix comments Mar 24, 2025
chenjincong and others added 3 commits March 24, 2025 14:46
fix
0eebb9e 
Signed-off-by: chenjincong <chenjincong@baidu.com>
@Chen-0210
fix
af02da3 
Signed-off-by: Chen-0210 <chenjincong11@gmail.com>
@Chen-0210
fix
71905f8 
Signed-off-by: Chen-0210 <chenjincong11@gmail.com>
@WoosukKwon WoosukKwon merged commit 0893567 into vllm-project:main Mar 24, 2025
5 of 8 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@Chen-0210 @erictang000
[V1][Minor] fix comments (vllm-project#15392)
11e9047 
Signed-off-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Chen-0210 <chenjincong11@gmail.com>
Co-authored-by: chenjincong <chenjincong@baidu.com>
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@Chen-0210 @wrmedford
[V1][Minor] fix comments (vllm-project#15392)
9684618 
Signed-off-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Chen-0210 <chenjincong11@gmail.com>
Co-authored-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Chen-0210 @lulmer
[V1][Minor] fix comments (vllm-project#15392)
2177aca 
Signed-off-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Chen-0210 <chenjincong11@gmail.com>
Co-authored-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@Chen-0210 @lk-chen
[V1][Minor] fix comments (vllm-project#15392)
c655fde 
Signed-off-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Chen-0210 <chenjincong11@gmail.com>
Co-authored-by: chenjincong <chenjincong@baidu.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Chen-0210 @shreyankg
[V1][Minor] fix comments (vllm-project#15392)
8454545 
Signed-off-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Chen-0210 <chenjincong11@gmail.com>
Co-authored-by: chenjincong <chenjincong@baidu.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Chen-0210
[V1][Minor] fix comments (vllm-project#15392)
8afc01b 
Signed-off-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Chen-0210 <chenjincong11@gmail.com>
Co-authored-by: chenjincong <chenjincong@baidu.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat left review comments

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Chen-0210 @WoosukKwon @robertgshaw2-redhat