Skip to content

[V1][Spec Decode] Update target_logits in place for rejection sampling #15427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

[V1][Spec Decode] Update target_logits in place for rejection sampling #15427

merged 1 commit into from
Mar 25, 2025

Conversation

@WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Mar 25, 2025

Addresses #15063 (comment)

@WoosukKwon
[V1][Spec Decode] Update target_logis in place
1f3d8f9 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 25, 2025
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 25, 2025
@WoosukKwon WoosukKwon changed the title [V1][Spec Decode] Update target_logis in place [V1][Spec Decode] Update target_logits in place for rejection sampling Mar 25, 2025
@WoosukKwon
Copy link
Collaborator Author

WoosukKwon commented Mar 25, 2025

cc @houseroad @njhill

houseroad
houseroad approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyTorch advanced indexing should return a tensor with new storage. Looks good.

@WoosukKwon WoosukKwon merged commit 25f560a into main Mar 25, 2025
42 of 44 checks passed
@WoosukKwon WoosukKwon deleted the inplace-rej branch March 25, 2025 04:04
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@WoosukKwon @erictang000
[V1][Spec Decode] Update target_logits in place for rejection sampling (
184da7e 
vllm-project#15427)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@WoosukKwon @wrmedford
[V1][Spec Decode] Update target_logits in place for rejection sampling (
e69157b 
vllm-project#15427)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@WoosukKwon @lulmer
[V1][Spec Decode] Update target_logits in place for rejection sampling (
79495c2 
vllm-project#15427)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@WoosukKwon @lk-chen
[V1][Spec Decode] Update target_logits in place for rejection sampling (
103e6ea 
vllm-project#15427)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@WoosukKwon @shreyankg
[V1][Spec Decode] Update target_logits in place for rejection sampling (
abc5dbb 
vllm-project#15427)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@WoosukKwon
[V1][Spec Decode] Update target_logits in place for rejection sampling (
de881c1 
vllm-project#15427)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WoosukKwon @houseroad