Skip to content

Conversation

@SzymonOzog
Copy link
Contributor

@SzymonOzog SzymonOzog commented Mar 25, 2025

Just realized that the names for MoE macros are conflicting with MMQ ones at

#define MMQ_Y_Q4_0 32

Not an issue at the moment because they are the same but might cause bugs in the future

Signed-off-by: SzymonOzog <szymon.ozog@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think we should separate the MoE kernel out from gguf_kernel.cu to a gguf_moe_kernel.cu and tight it to the moe extension. So that it would be much easier to maintain the GGUF kernel. (In fact, I'm planning an update for GGUF kernel to catchup the MMA support in llama.cpp, but haven't had enough bandwidth to do it yet)

Anyway, we can leave that to be done in a following PR.

@Isotr0py Isotr0py enabled auto-merge (squash) March 25, 2025 10:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 25, 2025
@SzymonOzog
Copy link
Contributor Author

Great! I've also started reading the MMA kernels from llama.cpp and will try to adapt MoE

@Isotr0py Isotr0py merged commit a608160 into vllm-project:main Mar 25, 2025
69 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
…5456)

Signed-off-by: SzymonOzog <szymon.ozog@gmail.com>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…5456)

Signed-off-by: SzymonOzog <szymon.ozog@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…5456)

Signed-off-by: SzymonOzog <szymon.ozog@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants