Skip to content

Conversation

@zou3519
Copy link
Collaborator

@zou3519 zou3519 commented Mar 25, 2025

Test Plan:

  • I ran vllm serve meta-llama/Llama-3.2-1B-Instruct locally and verified that vllm_compile_cache.py's filenames look like the following:
/home/rzou/.cache/vllm/torch_compile_cache/a785fdbf18/rank_0_0/inductor_cache/w2/cw22szhsitonk3z4ek
x476g3hzaet3vy5qmsoewpx3kgbokhcob2.py')}

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@zou3519 zou3519 force-pushed the fix_inductor_filenames branch 2 times, most recently from f4d2ed7 to b76a150 Compare March 25, 2025 19:39
Test Plan:
- I ran `vllm serve meta-llama/Llama-3.2-1B-Instruct` locally and
  verified that vllm_compile_cache.py's filenames look like the following:

```
/home/rzou/.cache/vllm/torch_compile_cache/a785fdbf18/rank_0_0/inductor_cache/w2/cw22szhsitonk3z4ek
x476g3hzaet3vy5qmsoewpx3kgbokhcob2.py')}
```

Signed-off-by: rzou <zou3519@gmail.com>

Signed-off-by:  <zou3519@gmail.com>
@zou3519 zou3519 force-pushed the fix_inductor_filenames branch from b76a150 to 69a2dd7 Compare March 25, 2025 21:20
@zou3519 zou3519 marked this pull request as ready for review March 26, 2025 13:00
@zou3519
Copy link
Collaborator Author

zou3519 commented Mar 26, 2025

cc @youkaichao could you review this please?

Signed-off-by: youkaichao <youkaichao@gmail.com>
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! i added the logic from pytorch 2.5, when file_path = inductor_compiled_graph.current_callable is not a function from closure, hoping it will be more robust.

@youkaichao
Copy link
Member

@zou3519 looking forward to the interface from inductor to get the hash key and the final file path from pytorch, so that we don't need to hack it in the future!

@youkaichao youkaichao merged commit 6278bc8 into vllm-project:main Mar 27, 2025
6 of 8 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Signed-off-by: <zou3519@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: <zou3519@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: <zou3519@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: <zou3519@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: <zou3519@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants