Skip to content

[V1][Minor] Use SchedulerInterface type for engine scheduler field #15499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

[V1][Minor] Use SchedulerInterface type for engine scheduler field #15499

merged 1 commit into from
Mar 25, 2025

Conversation

@njhill
Copy link
Member

@njhill njhill commented Mar 25, 2025 •
edited by github-actions bot
Loading

So that IDEs know what the methods are.

@njhill
[V1][Minor] Use SchedulerInterface type for engine scheduler field
90e110e 
So that IDEs know what the methods are.

Signed-off-by: Nick Hill <nhill@redhat.com>
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 25, 2025
WoosukKwon
WoosukKwon approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@WoosukKwon WoosukKwon merged commit 6aa196c into main Mar 25, 2025
13 of 16 checks passed
@WoosukKwon WoosukKwon deleted the scheduler-interface branch March 25, 2025 21:21
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@njhill @wrmedford
[V1][Minor] Use SchedulerInterface type for engine scheduler field (v…
52b230c 
…llm-project#15499)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Wes Medford <wryanmedford@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@njhill @lulmer
[V1][Minor] Use SchedulerInterface type for engine scheduler field (v…
bfb1547 
…llm-project#15499)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@njhill @lk-chen
[V1][Minor] Use SchedulerInterface type for engine scheduler field (v…
1580bbd 
…llm-project#15499)

Signed-off-by: Nick Hill <nhill@redhat.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@njhill @shreyankg
[V1][Minor] Use SchedulerInterface type for engine scheduler field (v…
d864693 
…llm-project#15499)

Signed-off-by: Nick Hill <nhill@redhat.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@njhill
[V1][Minor] Use SchedulerInterface type for engine scheduler field (v…
abdab87 
…llm-project#15499)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njhill @WoosukKwon