Skip to content

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 26, 2025

Fix all issues reported by torchfix.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Mar 26, 2025
Signed-off-by: cyy <cyyever@outlook.com>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, thanks for modernizing this code!

@DarkLight1337
Copy link
Member

Can you fix the pre-commit errors?

Signed-off-by: cyy <cyyever@outlook.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 26, 2025 09:01
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 26, 2025
@DarkLight1337 DarkLight1337 merged commit 1aa162e into vllm-project:main Mar 26, 2025
46 of 48 checks passed
@cyyever cyyever deleted the torch_fix branch March 26, 2025 14:45
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: cyy <cyyever@outlook.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: cyy <cyyever@outlook.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants