-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Bugfix] Fix Mllama interleaved images input support #15564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix Mllama interleaved images input support #15564
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be better to put this hack in get_replacement_mllama?
I ran the tests in my local env and get the following errors: I'm expecting this PR to fix it #14883. How can you pass the interleaved image tests? |
Hmmm, that's weird... I re-ran the test locally again, and it can still pass. The only change I made is changing the test to use |
Co-authored-by: Chen Zhang <zhangch99@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Slack Discussion: https://vllm-dev.slack.com/archives/C07QCGVDNUF/p1743003881430129?thread_ts=1743001000.770969&cid=C07QCGVDNUF
cc @heheda12345