Skip to content

[Frontend] update priority for --api-key and VLLM_API_KEY #15588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

[Frontend] update priority for --api-key and VLLM_API_KEY #15588

merged 1 commit into from
Mar 28, 2025

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Mar 27, 2025 •
edited by github-actions bot
Loading

FIX #15568 (link existing issues this PR will resolve)

@github-actions
Copy link

github-actions bot commented Mar 27, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Mar 27, 2025
@reidliu41
[Frontend] update priority for --api-key and VLLM_API_KEY
e6936e3 
Signed-off-by: reidliu41 <reid201711@gmail.com>
@reidliu41 reidliu41 force-pushed the fix-api-key-priority branch from b083d68 to e6936e3 Compare March 27, 2025 02:32
youkaichao
youkaichao approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 28, 2025 09:36
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 28, 2025
@youkaichao youkaichao disabled auto-merge March 28, 2025 11:40
@youkaichao youkaichao merged commit fd5fd26 into vllm-project:main Mar 28, 2025
40 of 42 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@reidliu41 @Alex4210987
[Frontend] update priority for --api-key and VLLM_API_KEY (vllm-proje…
90b03a0 
…ct#15588)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@reidliu41 @lulmer
[Frontend] update priority for --api-key and VLLM_API_KEY (vllm-proje…
c33b13f 
…ct#15588)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @lk-chen
[Frontend] update priority for --api-key and VLLM_API_KEY (vllm-proje…
a5646b8 
…ct#15588)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@reidliu41 @shreyankg
[Frontend] update priority for --api-key and VLLM_API_KEY (vllm-proje…
37d9485 
…ct#15588)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@reidliu41
[Frontend] update priority for --api-key and VLLM_API_KEY (vllm-proje…
c2620e4 
…ct#15588)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youkaichao youkaichao youkaichao approved these changes

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: --api-key argument ignored when VLLM_API_KEY is set

3 participants

@reidliu41 @youkaichao @houseroad